Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window's UDF doc changes. #2092

Merged

Conversation

big-andy-coates
Copy link
Contributor

Description

doc changes requested by @JimGalasyn for the window's UDF stuff. (Picked up after main PR merged).

Also worth including in this PR is this suggestion/comment by @blueedgenick #2090 (comment)

Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@big-andy-coates big-andy-coates changed the base branch from master to 5.0.x October 24, 2018 23:29
@big-andy-coates big-andy-coates changed the base branch from 5.0.x to master October 24, 2018 23:29
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@big-andy-coates big-andy-coates merged commit abdf474 into confluentinc:master Nov 1, 2018
@big-andy-coates big-andy-coates deleted the window_udf_doc_changes branch November 1, 2018 21:19
big-andy-coates added a commit that referenced this pull request Nov 1, 2018
(cherry picked from commit abdf474)
big-andy-coates added a commit that referenced this pull request Nov 1, 2018
(cherry picked from commit abdf474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants