Bring version checker improvements to 5.1.x #2240
Conversation
|
Thanks @hjafarpour.. Was this tested with the server to make sure that things continue to work? |
|
@apurvam I tested it manually with the |
|
Why are there two commits? this should just cherry pick from master on to 5.1 and have exactly one commit. |
|
The other PR had 27 commits so it was easier to just apply the changes directly. Also there are conflicting changes in master that are not in 5.1 which version checker relied on. |
Not sure I follow. There is just one commit on master 610a518 Did you do Or was it something else? I think we should only use git cherry pick for operations like this, and document any conflicts that had to be resolved in the description / commit message. Makes the review much easier. |
* Added isActive field to the ksql support metrics. * Added tests. * Updated the active status detection interval to 24 hours. * Applied review feedback. * Some refactoring. * Fix tests * Added to standalone. * Test fix * Refactoring based on Andy's feedabck. * Refactoring with Andy! * Change frequency to hour. * CHange the frequency back to 24 hours. * More changes addressing feedback. * Added a comment. * Temp commit * Applied the feedback. * Applied more feedback * more feedback! * Final feedback from Andy! * Feedback from Victoria.
hjafarpour
force-pushed
the
Bring-Version-Checker-Improvements-To-5-1
branch
from
6f4a443
to
f1e4fbc
Compare
|
@apurvam changed it to one commit using cherry pick as you suggested. |
Description
This PR brings the version checker improvement to 5.1.x. The improvements were initially merged into master but we want to include it in 5.1 release.
The original PR that was merged into master is #2020 .
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist