#1938 GEO_DISTANCE function broken by new UDF Invoker

[uurl]

Description

This PR fixes #1938 GEO_DISTANCE function broken by new UDF Invoker

Testing done

mvn clean package

Reviewer checklist

• Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
• Ensure relevant issues are linked (description should include text like "Fixes #")

[agavra]

Thanks @uurl! I think the preferred approach, however, would be to move this to the new UDF framework (e.g. using the @UdfDescription annotation, you can see an example in DateToString.java). This way, it will require primitives (non-null) to match the function without the explicit null checks simply by looking at the signature of the method and seeing primitives as parameters.

I would also recommend that you add a test for this using our QueryTranslationTest framework, which you can see an example in datestring.json, including a case for when it should _not _work (e.g. nulls are passed in). To see an example syntax for expected exception take a look at cast.json

[agavra]

This is looking really good! Just a few comments in-line :)

[agavra]

Thanks @uurl! Some more comments in-line, also please check why the tests are failing https://jenkins.confluent.io/job/confluentinc-pr/job/ksql/job/PR-2700/12/testReport/ - I think the comments that I have given will address them, but you can run the tests locally with mvn clean install

[agavra]

LGTM! Thanks for the contribution @uurl - we may need to rebase to get the tests passing, the current failure seems unrelated to your change. I'll ask some folk to give you a second review and then we can get this merged.

[uurl]

@agavra @rodesai @vcrfxia @big-andy-coates Ready

[vcrfxia]

Thanks for the contribution, @uurl ! Apologies I've left so many nits, but they shouldn't take long to address and I'm happy to get this merged for you as soon as that happens.

[uurl]

@vcrfxia Ready, thanks

[vcrfxia]

Thanks so much @uurl -- merging now!