Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: authorization filter is logging incorrect username #3138

Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix: authorization filter is logging incorrect username #3138

merged 1 commit into from
Jul 29, 2019

Conversation

spena
Copy link
Member

@spena spena commented Jul 26, 2019

Description

Fix a logging issue in the Authorization filter which was displaying the Principal object instead of the user name.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena added this to the 5.4 milestone Jul 26, 2019
@spena spena requested a review from a team July 26, 2019 19:51
@spena spena self-assigned this Jul 26, 2019
agavra
agavra approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@agavra agavra requested a review from a team July 26, 2019 19:56
@spena spena merged commit b15c6d0 into confluentinc:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

Assignees

@spena spena

Labels
None yet
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spena @agavra