feat: spin up a connect worker embedded inside the KSQL JVM #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
force-pushed
the
connect_embedded
branch
from
2e8e44b
to
19a2f30
Compare
rodesai
approved these changes
Aug 22, 2019
| connect = connectDistributed.startConnect(workerProps); | ||
| } catch (final ConnectException e) { | ||
| if (e.getCause() instanceof IOException && e.getCause().getCause() instanceof BindException) { | ||
| LOG.warn("Cannot start a local connect instance because connect is running locally!", e); |
ksql-rest-app/src/test/java/io/confluent/ksql/rest/server/MultiExecutableTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables KSQL to start a Connect distributed worker embedded in the KSQL server. The configuration is specified in
ksql.connect.worker.config, which behaves identically to a normal connect worker.Testing done
Local testing and some minor unit test coverage
Reviewer checklist