feat(static): switch partial datetime parser to use UTC by default #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change the ROWTIME rewriter and static queries will use UTC by default for datetime strings, if not explicit timezone is provided.
agavra
approved these changes
Oct 3, 2019
| @@ -43,44 +43,44 @@ public void init() { | |||
| @Test | |||
| public void shouldParseYear() { | |||
| // When: | |||
| assertThat(parser.parse("2017"), is(fullParse("2017-01-01T00:00:00.000"))); | |||
| assertThat(parser.parse("2017"), is(fullParse("2017-01-01T00:00:00.000+0000"))); | |||
There was a problem hiding this comment.
we shouldn't need all of these +0000s after this change, right?
There was a problem hiding this comment.
Yes we do. The 'fullParse' is expecting a tz - this makes the tests very explicit as to what timezone is expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change the ROWTIME rewriter and static queries will use UTC by default for datetime strings, if not explicit timezone is provided.
Testing done
USual
Reviewer checklist