fix: fix Avro schema validation #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Oct 9, 2019
| schema.valueSchema(), | ||
| "books" + KsqlConstants.SCHEMA_REGISTRY_VALUE_SUFFIX | ||
| "books_value", |
There was a problem hiding this comment.
SCHEMA_REGISTRY_VALUE_SUFFIX has a dash, not an underscore. Does this discrepancy matter? (I see the name is used for the schema name and named map fields. Can't tell how these names are used, though.)
rodesai
force-pushed
the
fix-avro-schema-validation
branch
from
9ff2866
to
8e47a9c
Compare
This patch fixes how we check schema compatibility for new streams/tables. Previously, we had our own code for generating an avro schema that was just used to generate the schema used to check for compatibility. The schema we actually write to the registry is generated by the avro serializer and avro converter. Now we use this schema when checking compatibility as well.
The previous commit switched us over to using the avro serializer to generate avro schemas from ksql schemas. This patch cleans up the ksql code for generating avro schemas.
rodesai
force-pushed
the
fix-avro-schema-validation
branch
from
8e47a9c
to
dab46b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: use the right schema for checking compatibility
This patch fixes how we check schema compatibility for new streams/tables.
Previously, we had our own code for generating an avro schema that was just
used to generate the schema used to check for compatibility. The schema we
actually write to the registry is generated by the avro serializer and
avro converter. Now we use this schema when checking compatibility as well.
How to review: