Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(3524): improve pull query error message (MINOR) #3540

Merged
merged 1 commit into from
Oct 11, 2019
Merged

fix(3524): improve pull query error message (MINOR) #3540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/test/resources/rest-query-validation-tests/materialized-aggregate-static-queries.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlStatementErrorMessage",
"message": "Table 'X' is not materialized. KSQL currently only supports static queries on materialized aggregate tables. i.e. those created by a 'CREATE TABLE AS SELECT <fields> FROM <sources> GROUP BY <key>' style statement.",
"message": "Table 'X' is not materialized. KSQL currently only supports static queries on materialized aggregate tables. i.e. those created by a 'CREATE TABLE AS SELECT <fields>, <aggregate_functions> FROM <sources> GROUP BY <key>' style statement.",
"status": 400
}
},
Expand Down
3 changes: 2 additions & 1 deletion ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,8 @@ private static KsqlException notMaterializedException(final SourceName sourceTab
"Table '" + sourceTable.toString(FormatOptions.noEscape()) + "' is not materialized."
+ " KSQL currently only supports static queries on materialized aggregate tables."
+ " i.e. those created by a"
+ " 'CREATE TABLE AS SELECT <fields> FROM <sources> GROUP BY <key>' style statement.");
+ " 'CREATE TABLE AS SELECT <fields>, <aggregate_functions> "
+ "FROM <sources> GROUP BY <key>' style statement.");
}

private static KsqlException invalidWhereClauseException(
Expand Down