fix: Created new test for running topology generation manually from t… #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he IDE, and removed main() from TopologyFileGenerator
agavra
approved these changes
Oct 17, 2019
| @@ -86,10 +86,6 @@ | |||
| private TopologyFileGenerator() { | |||
| } | |||
|
|
|||
| public static void main(final String[] args) throws Exception { | |||
There was a problem hiding this comment.
Would you mind adding a link in the JavaDoc of this class to the test people should use to run this, i.e. link to the new ManualTopologyFileGeneratorTest test. Otherwise, people may struggle to find it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3607
TopologyFileGenerator should only be run as a test as it requires test dependencies.
This PR removes the main() from the class to avoid temptation to run it directly in the IDE.
A new ignore manually test is added which should be run manually to generate the topology stuff.
Testing done
N/A
Reviewer checklist