fix: include lower-case identifiers among those that need quotes #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Nov 4, 2019
rodesai
force-pushed
the
add-quotes-to-lower-case
branch
from
0d31c22
to
3e0fac4
Compare
IdentifierUtils::needsQuotes is used by various code that formats SQL text to decide what identifiers to wrap in quotes. Before this change, this just included reserved identifiers. However, identifiers that include lower-case characters should also be quoted. Otherwise, when the parser parses them it will convert them to upper-case. So this patch changes needsQuotes to check for lower-case characters. For schema inference, we don't want to quote column names generated from lower-case avro schema fields. To handle this, this patch adds IdentifierUtils.isValid, that only returns true if the identifier is valid (parsable). Schema inference uses this to only quote invalid identifiers.
rodesai
force-pushed
the
add-quotes-to-lower-case
branch
from
3e0fac4
to
113eedb
Compare
stevenpyzhang
pushed a commit
to stevenpyzhang/ksql
that referenced
this pull request
Apr 22, 2020
…fluentinc#3723) IdentifierUtils::needsQuotes is used by various code that formats SQL text to decide what identifiers to wrap in quotes. Before this change, this just included reserved identifiers. However, identifiers that include lower-case characters should also be quoted. Otherwise, when the parser parses them it will convert them to upper-case. So this patch changes needsQuotes to check for lower-case characters. For schema inference, we don't want to quote column names generated from lower-case avro schema fields. To handle this, this patch adds IdentifierUtils.isValid, that only returns true if the identifier is valid (parsable). Schema inference uses this to only quote invalid identifiers.
2 tasks
stevenpyzhang
added a commit
that referenced
this pull request
Apr 22, 2020
…) (#5139) IdentifierUtils::needsQuotes is used by various code that formats SQL text to decide what identifiers to wrap in quotes. Before this change, this just included reserved identifiers. However, identifiers that include lower-case characters should also be quoted. Otherwise, when the parser parses them it will convert them to upper-case. So this patch changes needsQuotes to check for lower-case characters. For schema inference, we don't want to quote column names generated from lower-case avro schema fields. To handle this, this patch adds IdentifierUtils.isValid, that only returns true if the identifier is valid (parsable). Schema inference uses this to only quote invalid identifiers. Co-authored-by: Rohan <desai.p.rohan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IdentifierUtils::needsQuotesis used by various code that formats SQL text to decide what identifiers to wrap in quotes. Before this change, this just included reserved identifiers. However, identifiers that include lower-case characters should also be quoted. Otherwise, when the parser parses them it will convert them to upper-case.