Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhance test framework to support primitive keys #4201

Merged

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Dec 30, 2019

Description

Enhanced the test framework to work with test cases with BIGINT and DOUBLE keys. This was previously failing due to Jackson deserializing the JSON describing the expected values into to INT and DECIMAL.

To achieve this I've started to tidy up the mess in the test framework. Specifically, we no longer track the serde to use in the Topic class, as this is constructed when parsing the test cases. Doing so was problematic as it was hard to know what serde should be used just from the test case text. The serde to use is now determined by looking at the format of sources in the metastore once the SQL statements have been executed.

Also includes some additional test cases for pull queries working with primitive keys, and pulling out the code that determines the format / serde to use for a topic into a TopicInfoCache, as this is not shared by QTT and RQTT tests.

Testing done

mvn integration-test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner December 30, 2019 15:08
Conflicting files
ksql-functional-tests/src/main/java/io/confluent/ksql/test/tools/TestExecutor.java
@big-andy-coates
Copy link
Contributor Author

test this please

@big-andy-coates
Copy link
Contributor Author

retest this please

@big-andy-coates
Copy link
Contributor Author

Merging without review as its test only change...

@big-andy-coates big-andy-coates merged commit e41d8ee into confluentinc:master Jan 2, 2020
@big-andy-coates big-andy-coates deleted the prim_key_func_test branch January 2, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant