-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Include functional tests jar in docker images #4274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this LGTM! I think it's much cleaner to have this be a single module at the end than what we currently have.
But.... hate to do this to you 😂 can you please merge #4260 with this? Also, open up a ticket to delete the old dockerfiles etc.. after we've migrated the Jenkins job to build from these ones.
963e70c
to
9ef345e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed not needed files rename module remove docker compose file
c77ad0f
to
1cb912b
Compare
Description
Fixes #3989
We need to include the functional tests jar in the docker image. Instead of creating two new modules that will build the two images for server and cli respectively, we decided to build a single image for both server and cli that will be called ksqldb.
This PR adds a new module that is used only for building the ksqldb docker image. (The actual name of the image (ksqldb) will be assigned by the jenkins tool.)
Testing done
Tried the docker image and am able to run server, cli and testing tool.
a. Open terminal into container:
b. Create files
input.json
,output.json
,statement.json
and copy into containerc. Copy test jars into `/usr/share/java/ksql-rest-app/
d. Run testing tool:
e. Output is:
Tried same steps with image created from jenkins script.
Tried quickstart (https://ksqldb.io/quickstart.html), currently fails due to : #4400 .
Reviewer checklist
Docs for using the testing tool with docker image need to get created/updated!