feat: display errors in CLI in red text #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueedgenick
changed the title
vcrfxia
approved these changes
Feb 14, 2020
|
@blueedgenick finally got past all the Jenkins build issues and am seeing a couple failing tests now:
I'm able to reproduce locally. Do you have time to take a look? |
|
Thanks Victoria - i will take a look this afternoon
…On Tue, Feb 18, 2020 at 11:04 AM Victoria Xia ***@***.***> wrote:
@blueedgenick <https://github.com/blueedgenick> finally got past all the
Jenkins build issues and am seeing a couple failing tests now:
-
io.confluent.ksql.cli.console.ConsoleTest.testPrintErrorStreamedRow[JSON]
-
io.confluent.ksql.cli.console.ConsoleTest.testPrintErrorStreamedRow[TABULAR]
I'm able to reproduce locally. Do you have time to take a look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4509?email_source=notifications&email_token=ABCXJID2YZLDIOGLWOPGKK3RDQWK3A5CNFSM4KSXU5J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMDSERY#issuecomment-587670087>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCXJIBWAI6YWDIFBML37CDRDQWK3ANCNFSM4KSXU5JQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply renders error messages displayed in the CLI in red (see #892 ).
@rmoff - this is for you ;-)