fix: Infer TLS based on scheme of server string #4891

purplefox · 2020-03-25T09:15:26Z

Fixes: #4885

Now we infer whether tls is enabled for the KsqlRestClient based on the server connect string.

Updated tests

Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
Ensure relevant issues are linked (description should include text like "Fixes #")

ksqldb-rest-client/src/main/java/io/confluent/ksql/rest/client/KsqlRestClient.java

vcrfxia · 2020-03-25T21:15:11Z

Hey @purplefox , I found a slight issue with this fix and opened #4893 to address it. What do you think?

purplefox · 2020-04-01T12:19:37Z

@vcrfxia Do you see any further issues with this (based on #4893 being merged too). If not could you approve?

purplefox · 2020-04-01T12:52:35Z

Ah, nvm, didn't realise you already merged the other one!

fix: infer tls based on scheme of server string

9aacc1c

purplefox requested a review from a team as a code owner March 25, 2020 09:15

purplefox changed the title ~~fix: infer tls based on scheme of server string~~ fix: Infer TLS based on scheme of server string Mar 25, 2020

purplefox requested a review from vcrfxia March 25, 2020 10:56

vcrfxia reviewed Mar 25, 2020

View reviewed changes

ksqldb-rest-client/src/main/java/io/confluent/ksql/rest/client/KsqlRestClient.java Outdated Show resolved Hide resolved

check server name case agnostic

0a02da1

vcrfxia mentioned this pull request Mar 25, 2020

fix: Infer TLS based on scheme of server string #4893

Merged

2 tasks

purplefox closed this Apr 1, 2020

purplefox deleted the infer_tls_from_scheme branch April 28, 2020 07:21

Provide feedback