Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Do not allow access to new streaming endpoints using HTTP1.x #5193

Merged
merged 4 commits into from Apr 27, 2020
Merged

feat: Do not allow access to new streaming endpoints using HTTP1.x #5193

merged 4 commits into from Apr 27, 2020

Conversation

purplefox
Copy link
Contributor

Description

Implements: #4604

Reject access to the new streaming endpoints when attempted using HTTP1.1.

Testing done

Added new tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@purplefox purplefox requested a review from a team as a code owner April 27, 2020 10:59
@purplefox purplefox changed the title feat: Do not allow access to new streaming endpoints using HTTP11 feat: Do not allow access to new streaming endpoints using HTTP1.x Apr 27, 2020
@purplefox purplefox requested a review from vcrfxia April 27, 2020 15:00
agavra
agavra approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@purplefox purplefox merged commit 8b90035 into confluentinc:master Apr 27, 2020
@purplefox purplefox deleted the reject_http11_access branch April 28, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

@vcrfxia vcrfxia Awaiting requested review from vcrfxia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@purplefox @agavra