Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow structs in schema provider return types #5287

Merged
merged 2 commits into from
May 7, 2020

Conversation

agavra
Copy link
Contributor

@agavra agavra commented May 5, 2020

fixes #5286

Description

This PR allows resolution to a ParamType of StructType for udf methods that have the java return type of Connect's Struct class. The user experience isn't great, as they need to specify the return of the udf using SqlType but the return object as a Connect Struct but that will be follow-up work.

NOTE: The fix is the two lines in UdfUtil, the rest is testing

Testing done

Unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra requested a review from vpapavas May 5, 2020 23:28
Copy link
Member

@vpapavas vpapavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vpapavas vpapavas self-assigned this May 5, 2020
@agavra agavra marked this pull request as ready for review May 7, 2020 17:57
@agavra agavra requested a review from a team as a code owner May 7, 2020 17:57
@agavra agavra merged commit 2e604f0 into confluentinc:master May 7, 2020
@agavra agavra deleted the fix_struct_provider branch May 7, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UdfSchemaProvider doesn't work with Structs
2 participants