Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop WITH(KEY) syntax #5363

Merged
merged 21 commits into from
May 18, 2020
Merged

feat: drop WITH(KEY) syntax #5363

merged 21 commits into from
May 18, 2020

Commits on May 14, 2020

  1. feat: drop WITH(KEY) syntax 

    fixes: confluentinc/ksql#3537

implements: See [KLIP-25](https://github.com/confluentinc/ksql/blob/master/design-proposals/klip-25-removal-of-with-key-syntax.md)

This change removes the `WITH(KEY)` syntax which previously allowed users to specify a value column that could act as an alias for the key column. This allowed a more user friendly name to be used for the key column, at the expense of requiring a copy of the key data in the value.

With the new 'any key name' feature, the key columns themselves can be given appropriate names, removing the need for this aliasing functionality.  See [KLIP-25](https://github.com/confluentinc/ksql/blob/master/design-proposals/klip-25-removal-of-with-key-syntax.md) for more details.
    @big-andy-coates
    big-andy-coates committed May 14, 2020
    Configuration menu
    Copy the full SHA
    a807f83 View commit details
    Browse the repository at this point in the history

  2. test: test updates

    @big-andy-coates
    big-andy-coates committed May 14, 2020
    Configuration menu
    Copy the full SHA
    a9d5f1b View commit details
    Browse the repository at this point in the history

  3. test: historic plans

    @big-andy-coates
    big-andy-coates committed May 14, 2020
    Configuration menu
    Copy the full SHA
    283679a View commit details
    Browse the repository at this point in the history

  4. docs: doc updates

    @big-andy-coates
    big-andy-coates committed May 14, 2020
    Configuration menu
    Copy the full SHA
    d4c7d68 View commit details
    Browse the repository at this point in the history

  5. Update docs/developer-guide/joins/partition-data.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    3b95f87 View commit details
    Browse the repository at this point in the history

  6. Update docs/developer-guide/joins/partition-data.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    6aa7f70 View commit details
    Browse the repository at this point in the history

  7. Update docs/developer-guide/joins/partition-data.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    3a74a30 View commit details
    Browse the repository at this point in the history

  8. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    0e616ff View commit details
    Browse the repository at this point in the history

  9. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    7c15340 View commit details
    Browse the repository at this point in the history

  10. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    adc8594 View commit details
    Browse the repository at this point in the history

  11. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    4a7322c View commit details
    Browse the repository at this point in the history

  12. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    d2da5eb View commit details
    Browse the repository at this point in the history

  13. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    7390a34 View commit details
    Browse the repository at this point in the history

  14. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    dbf9677 View commit details
    Browse the repository at this point in the history

  15. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    5acab89 View commit details
    Browse the repository at this point in the history

  16. Update docs/developer-guide/create-a-stream.md 

    Co-authored-by: Jim Galasyn <jim.galasyn@confluent.io>
    @big-andy-coates @JimGalasyn
    big-andy-coates and JimGalasyn committed May 14, 2020
    Configuration menu
    Copy the full SHA
    058bfd3 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. chore: merge from master 

    Conflicting files
ksqldb-rest-app/src/test/java/io/confluent/ksql/rest/integration/LagReportingAgentFunctionalTest.java
    @big-andy-coates
    big-andy-coates committed May 15, 2020
    Configuration menu
    Copy the full SHA
    2559bc7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'remove_key_field' of github.com:big-andy-coates/ksql in… 

    …to remove_key_field
    @big-andy-coates
    big-andy-coates committed May 15, 2020
    Configuration menu
    Copy the full SHA
    10f1b9a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into remove_key_field

    @big-andy-coates
    big-andy-coates committed May 15, 2020
    Configuration menu
    Copy the full SHA
    2b809e3 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. chore: merge from master 

    Conflicting files
ksqldb-rest-app/src/test/java/io/confluent/ksql/api/integration/ApiIntegrationTest.java
    @big-andy-coates
    big-andy-coates committed May 18, 2020
    Configuration menu
    Copy the full SHA
    0362ad1 View commit details
    Browse the repository at this point in the history

  2. chore: disable spotbugs red herring

    @big-andy-coates
    big-andy-coates committed May 18, 2020
    Configuration menu
    Copy the full SHA
    ebc8053 View commit details
    Browse the repository at this point in the history