Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce RegexClassifier for classifying errors via cfg #5412

Merged
merged 1 commit into from
May 20, 2020

Conversation

agavra
Copy link
Contributor

@agavra agavra commented May 19, 2020

Description

This change introduces the ability to use config to classify errors as one of UNKNOWN, USER or SYSTEM (see #5374 for more information) via regex patterns.

Testing done

Tested with:

ksql.error.classifier.regex.1=USER .*task directory .* doesn't exist and couldn't be created.* 

And saw the following in the logs:

[2020-05-19 10:48:46,336] ERROR Unhandled exception caught in streams thread _confluent-ksql-default_query_CTAS_COUNTS_0-49406875-bc65-4fe2-9932-640c88dac8ae-StreamThread-3. (io.confluent.ksql.engine.KsqlEngine:43)
org.apache.kafka.streams.errors.ProcessorStateException: task directory [/tmp/kafka-streams/_confluent-ksql-default_query_CTAS_COUNTS_0/1_0] doesn't exist and couldn't be created
...
[2020-05-19 10:48:46,968] WARN Classified error for queryId _confluent-ksql-default_query_CTAS_COUNTS_0 under regex pattern .*task directory .* doesn't exist and couldn't be created.* as type USER. (io.confluent.ksql.query.RegexClassifier:71)

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@agavra agavra marked this pull request as ready for review May 19, 2020 18:52
@agavra agavra requested a review from a team as a code owner May 19, 2020 18:52
@agavra agavra requested a review from rodesai May 19, 2020 18:52
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agavra agavra merged commit b25dd98 into confluentinc:master May 20, 2020
@agavra agavra deleted the regex_classifier branch May 20, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants