fix: allow empty structs in schema inference #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanConfluent
approved these changes
Jun 19, 2020
| @@ -161,6 +161,9 @@ public String visitMap(final Schema schema, final String key, final String value | |||
| } | |||
|
|
|||
| public String visitStruct(final Schema schema, final List<? extends String> fields) { | |||
| if (fields.isEmpty()) { | |||
| return "STRUCT< >"; | |||
| } | |||
There was a problem hiding this comment.
Just curious, what does the below collector return with empty fields?
agavra
changed the title
agavra
added a commit
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, empty structs would be formatted as
STRUCT<>in theSqlSchemaFormatter(which for some reason is used independently ofSqlFormatter, we should dig into that) which would cause parsing to fail because<>is it's own symbol for "not equal to".This code path was not used in master after #4637 so it was no longer happening. That change has a relatively large surface area, so for the backport I am making the most targeted change possible to address the edge case.
Testing done
Added a unit test, which fails before this fix.
Reviewer checklist