Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ksqlDB should not truncate decimals #5763

Merged
merged 1 commit into from
Jul 6, 2020
Merged

fix: ksqlDB should not truncate decimals #5763

merged 1 commit into from
Jul 6, 2020

Conversation

big-andy-coates
Copy link
Contributor

Description

fixes: #4710

Fixes the JSON / JSON_SR formats to not remove trailing zeros from decimal values, e.g. 14.7600 should be processed and seriailized as 14.6700 and not 14.67.

Testing done

usual

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
fix: ksqlDB should not truncate decimals
f5b9aa2 
fixes: confluentinc/ksql#4710

Fixes the `JSON` / `JSON_SR` formats to not remove trailing zeros from decimal values, e.g. `14.7600` should be processed and seriailized as `14.6700` and _not_ `14.67`.
@big-andy-coates big-andy-coates requested a review from a team as a code owner July 3, 2020 15:31
spena
spena approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@big-andy-coates big-andy-coates merged commit 2b3ca33 into confluentinc:master Jul 6, 2020
@big-andy-coates big-andy-coates deleted the exact_decimals branch July 6, 2020 15:17
big-andy-coates added a commit that referenced this pull request Jul 8, 2020
@big-andy-coates
fix: ksqlDB should not truncate decimals (#5763)
ba833f7 
fixes: #4710

Fixes the `JSON` / `JSON_SR` formats to not remove trailing zeros from decimal values, e.g. `14.7600` should be processed and seriailized as `14.6700` and _not_ `14.67`.

Co-authored-by: Andy Coates <big-andy-coates@users.noreply.github.com>
(cherry picked from commit 2b3ca33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loss of precision of decimals when using Json.
2 participants
@big-andy-coates @spena