-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add serialization exceptions to processing logger #6084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! What's the current behavior on error for push queries?
Not sure I understand the question. Push queries use the same serializers and deserializers as persistent queriers so the logging behavior is the same. The name of the logger contains the query ID, which for the push queries is a random large number (in contrast to the sensible query IDs of persistent queries). If you're asking about the push query behavior for the particular linked issue that this PR fixes, push queries don't generate serialization errors in the examples in the issue since the example push queries don't write to any Kafka topics, so the serializer (where the error is generated) is unused. |
|
||
message.deserializationError.topic (STRING) | ||
|
||
: The Kafka topic of the record for which deserialization failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: The Kafka topic of the record for which deserialization failed. | |
: The {{ site.ak }} topic of the record for which deserialization failed. |
|
||
message.serializationError.topic (STRING) | ||
|
||
: The Kafka topic to which the ksqlDB row that failed to serialize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: The Kafka topic to which the ksqlDB row that failed to serialize | |
: The {{ site.ak }} topic to which the ksqlDB row that failed to serialize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few suggestions.
Description
Fixes #5364
Two changes in this PR (corresponding to the first two commits):
Struct schemas do not match.
) isn't particularly actionable by users.Testing done
Added unit tests. Manual testing underway.
Reviewer checklist