fix: Refactors rate limiter within LoggingHandler to be singleton #6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Dec 1, 2020
| this(ksqlRestConfig, RateLimiter::create); | ||
| } | ||
|
|
||
| public LoggingRateLimiter( |
There was a problem hiding this comment.
This looks like it should be package-private and marked as VisibleForTesting?
|
|
||
| public boolean shouldLog(final RoutingContext routingContext) { | ||
| if (rateLimitedPaths.containsKey(routingContext.request().path())) { | ||
| final String path = routingContext.request().path(); |
There was a problem hiding this comment.
Since only the path of the routing context is used here, would it make more sense to pass just the path into this method rather than the entire routing context?
There was a problem hiding this comment.
I was debating that a bit. At the moment it only rate limits based upon the path, but in the future, it could be broader. I'm fine to pass path now and revise in the future.
| } | ||
|
|
||
| @Test | ||
| public void shouldLog_notIncluded() { |
There was a problem hiding this comment.
nit (was confused by the name for a while):
Suggested change
| public void shouldLog_notIncluded() { | |
| public void shouldLog_notRateLimited) { |
There was a problem hiding this comment.
Done.
I agree, the name was unclear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the rate limiting logic within LoggingHandler to be a shared singleton. Otherwise the limit is multiplied by the number of server verticles.
Testing done
Ran unit tests and ran high qps requests manually to verify correct logging.
Reviewer checklist