feat(migrations): implement validate command
#7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
commented
Feb 24, 2021
| @@ -47,4 +55,105 @@ public static String getCurrentVersion(final MigrationConfig config, final Clien | |||
| String.format("Could not query %s: %s", migrationTableName, e.getMessage())); | |||
| } | |||
| } | |||
|
|
|||
| public static String getLatestMigratedVersion( | |||
There was a problem hiding this comment.
@jzaralim this method will be useful for implementing apply, in order to get the latest version to start applying commands from.
vcrfxia
commented
Feb 24, 2021
| /** | ||
| * @return true if validation passes, else false. | ||
| */ | ||
| static boolean validate( |
There was a problem hiding this comment.
This method is non-private since we'll want to call it from the apply command, in order to validate applied migrations prior to submitting any new ones ( cc @jzaralim )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
validatecommand of the migrations tool:applycommand should always use the latest MIGRATED version as "previous". Currently an error is thrown if this is not the case, but we can revisit when we introduce theabortcommand to get out of bad states due to race conditions.NONE_VERSION, indicating the first migration version has been reached.Once table scans are implemented, we can simplify the algorithm by simply doing a table scan and filtering for status MIGRATED.
Testing done
Lots of unit tests. Integration tests will be added with the
applyimplementation.Reviewer checklist