feat(migrations): implement info command
#7145
Conversation
| // verify FOO and BAR were registered | ||
| describeSource("FOO"); | ||
| describeSource("BAR"); | ||
|
|
||
| // verify current | ||
| final List<StreamedRow> current = makeKsqlQuery("SELECT * FROM migration_schema_versions WHERE VERSION_KEY='CURRENT';"); | ||
| assertThatEventually(() -> current.size(), is(2)); |
There was a problem hiding this comment.
These old assertThatEventually calls didn't actually do anything since current wasn't being refreshed (i.e., makeKsqlQuery() was only being called once, outside the assertThatEventually). I've gone through and cleaned up the usage of assertThatEventually in this test file.
| .map(LoggingEvent::getRenderedMessage) | ||
| .collect(Collectors.toList()); | ||
| assertThat(logMessages, hasItem(containsString("Current migration version: 2"))); | ||
| assertThat(logMessages, hasItem(matchesRegex( |
There was a problem hiding this comment.
This integration test uses a regex matcher since (1) the timestamp depends on when the test is run, and (2) the timezone used is local.
| public final class MigrationVersionInfo { | ||
|
|
||
| private static final String DATE_FORMAT = "yyyy-MM-dd HH:mm:ss.SSS z"; | ||
| private static final String EMPTY_MIGRATION_TIMESTAMP = "N/A"; |
There was a problem hiding this comment.
Should we also use this value for running migrations instead of an empty string?
There was a problem hiding this comment.
I don't feel strongly. I think we can leave it as is. In all likelihood, the only way users will view the contents of the metadata stream and table will be through migrations info, rather than inspecting the stream/table directly.
Description
This PR implements the
migrations infocommand. The command does two things: prints the current migration version, and prints a table with information about the different available migration versions.As part of implementing
info, this PR also adds a new column (error_reason) to the migrations metadata stream and table, and contains some minor refactors such as renamingMigrationtoMigrationFile, renamingVersionInfotoMigrationVersionInfoand moving it into its own file, and cleaning up some test code. The refactors are in the first few commits and can be reviewed separately if that's easier.Testing done
Unit + integration testing.
Reviewer checklist