Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(migrations): enable set/unset statements for migration tool #7190

Merged
merged 10 commits into from
Mar 10, 2021
Merged

feat(migrations): enable set/unset statements for migration tool #7190

merged 10 commits into from
Mar 10, 2021

Conversation

jzaralim
Copy link
Contributor

Description

As the title states. Start reviewing from feat(migrations): enable set/unset statements for migration tool

Testing done

Added unit and integration test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner March 10, 2021 09:11
vcrfxia
vcrfxia approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments inline. Thanks @jzaralim !

ksqldb-tools/src/main/java/io/confluent/ksql/tools/migrations/util/CommandParser.java Outdated Show resolved Hide resolved
ksqldb-tools/src/main/java/io/confluent/ksql/tools/migrations/util/CommandParser.java Show resolved Hide resolved
ksqldb-tools/src/main/java/io/confluent/ksql/tools/migrations/util/CommandParser.java Outdated Show resolved Hide resolved
...b-tools/src/main/java/io/confluent/ksql/tools/migrations/commands/ApplyMigrationCommand.java Show resolved Hide resolved
@jzaralim jzaralim merged commit 4151bae into confluentinc:master Mar 10, 2021
@jzaralim jzaralim deleted the set branch March 10, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzaralim @vcrfxia