Add ability to retry admin client calls on retriable exceptions #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguy
approved these changes
Feb 26, 2018
| int retries = 0; | ||
| while (retries < NUM_RETRIES) { | ||
| try { | ||
| if (0 < retries) { |
apurvam
force-pushed
the
786-add-retry-to-kafka-topic-client
branch
from
740976d
to
062c172
Compare
rodesai
reviewed
Feb 26, 2018
| } | ||
| } | ||
| throw new ExecutionException( | ||
| new RuntimeException("Could not complete admin operation even after " |
There was a problem hiding this comment.
It might be good to keep a copy of the last exception and pass it in as a cause here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes #786. See that issue for the context of the problem.
This patch introduces a
RetryHelperclass to theKafkaTopicClientImplwhich allows transparent retires of admin client calls when there are retriable exceptions. We should be retrying on these exceptions to have a robust implementation of the topic client.