feat: add CREATE SOURCE STREAM syntax and metadata info #8004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
reviewed
Aug 17, 2021
| @@ -1070,6 +1074,9 @@ | |||
| "leftJoinColumnName" : { | |||
| "type" : "string" | |||
| }, | |||
| "leftJoinExpression" : { | |||
There was a problem hiding this comment.
Why did this change? Is this move going to affect the historic plans?
There was a problem hiding this comment.
I got this by running KsqlPlanSchemaTest.runMeToRegenerateSchemaFile. Perhaps this change is related to another PR?
There was a problem hiding this comment.
Probably. You can manually reset that change and just leave the isSource field and see what happens. I have done that sometimes when I don't know why the schema or plan has changes I don't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The STREAM version of #7945.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist