feat: perform SchemaRegistry permissions on C*AS sink subjects #8039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
commented
Aug 23, 2021
Comment on lines
199
to
198
| keyFormat.supportsFeature(SerdeFeature.SCHEMA_INFERENCE) | ||
| ? SerdeFeatures.of(SerdeFeature.SCHEMA_INFERENCE) | ||
| : SerdeFeatures.of(), |
There was a problem hiding this comment.
keyFormat has a supportedFeatures() method that returns a set of features. I could call SerdeFeatures.from(keyFormat.supportedFeatures()) here, but SerdeFeatures.from throws an exception because of incompatible features returned. Because I just need SCHEMA_INFERENCE, then I just added this condition here.
There was a problem hiding this comment.
IIUC, the only way to hit the incompatible features exception is if UNWRAP_SINGLES and WRAP_SINGLES are both included. Why is that happening?
spena
force-pushed
the
sr_perms_check_sink_subject
branch
from
a3aed56
to
665422d
Compare
jzaralim
approved these changes
Aug 23, 2021
Comment on lines
199
to
198
| keyFormat.supportsFeature(SerdeFeature.SCHEMA_INFERENCE) | ||
| ? SerdeFeatures.of(SerdeFeature.SCHEMA_INFERENCE) | ||
| : SerdeFeatures.of(), |
There was a problem hiding this comment.
IIUC, the only way to hit the incompatible features exception is if UNWRAP_SINGLES and WRAP_SINGLES are both included. Why is that happening?
spena
force-pushed
the
sr_perms_check_sink_subject
branch
from
665422d
to
2e2ba6a
Compare
spena
force-pushed
the
sr_perms_check_sink_subject
branch
from
2e2ba6a
to
8630967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added SchemaRegistry permission checks to the sink subjects used by C*AS commands.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist