feat: execute source table query plans #8061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
force-pushed
the
source_table_query_execution
branch
2 times, most recently
from
94fd309
to
cba4762
Compare
spena
force-pushed
the
source_table_query_execution
branch
from
cba4762
to
09487c6
Compare
jzaralim
approved these changes
Aug 27, 2021
| @JsonProperty(value = "physicalPlan", required = true) final ExecutionStep<?> physicalPlan, | ||
| @JsonProperty(value = "queryId", required = true) final QueryId queryId | ||
| ) { | ||
| this.sources = ImmutableSortedSet.copyOf( | ||
| Comparator.comparing(Name::text), | ||
| Objects.requireNonNull(sources, "sources") | ||
| ); | ||
| this.sink = Objects.requireNonNull(sink, "sink"); | ||
| // Sink can be null when a query plan forms part of a create source table command. |
There was a problem hiding this comment.
Wouldn't that be Optional.empty() rather than null?
There was a problem hiding this comment.
I'll remove that comment. It added when I was testing the QueryPlan with nulls, but I found out later the Optional parameter works.
spena
force-pushed
the
source_table_query_execution
branch
2 times, most recently
from
2373945
to
dde78f6
Compare
spena
force-pushed
the
source_table_query_execution
branch
2 times, most recently
from
2c4299d
to
9915a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the source table materialization, this PR executes the new plan created for source tables.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist