Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update storage utilization metrics to start when app is initialized #8095

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

lct45
Copy link
Contributor

@lct45 lct45 commented Sep 2, 2021

Description

per https://confluentinc.atlassian.net/browse/KCI-938, make storage utilization per node metrics initialized when the app starts up. this means that even if the app has no queries, we'll still be getting metrics at the node level. previously, we'd only see node level metrics after we created a query

Testing done

kept existing unit tests

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@lct45 lct45 requested a review from a team as a code owner September 2, 2021 18:41
@lct45 lct45 requested a review from rodesai September 2, 2021 18:42
Copy link
Contributor

@rodesai rodesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lct45 lct45 merged commit 8add4ac into confluentinc:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants