Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: During ksql startup, avoid recreating deleted command topic when a valid backup exists #7753 #8257

Merged
merged 7 commits into from
Oct 20, 2021
Merged

fix: During ksql startup, avoid recreating deleted command topic when a valid backup exists #7753 #8257

merged 7 commits into from
Oct 20, 2021

Commits on Oct 14, 2021

  1. fix: Avoid recreating command topic when it has been deleted and a va… 

    …lid backup exists.
    @mkandaswamy
    mkandaswamy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    77bd8ea View commit details
    Browse the repository at this point in the history

  2. fix Integration test avoidRecreatingCommandTopicWithActiveBackup

    @mkandaswamy
    mkandaswamy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    0b54c09 View commit details
    Browse the repository at this point in the history

  3. Added a new unit test in CommandTopicBackupImplTest and fixed checkst… 

    …yle errors.
    @mkandaswamy
    mkandaswamy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    cf2e4f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Fixed unit test failure due to a NullPointerException. Also, improved… 

    … error messages.
    @mkandaswamy
    mkandaswamy committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    164fb35 View commit details
    Browse the repository at this point in the history

  2. Fix integration test failure. Also, refactor integration test code ch… 

    …anges into its own test file: QuickDegradeAndRestoreCommandTopicIntegrationTest
    @mkandaswamy
    mkandaswamy committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    995a19f View commit details
    Browse the repository at this point in the history

  3. Addressed Steven's review comment. Also, got rid of an unnecessary im… 

    …port in RestoreCommandTopicIntegrationTest
    @mkandaswamy
    mkandaswamy committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    3c1a338 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Addressed Steven's review comment by swapping check for degraded stat… 

    …e and topic exists in integration test.
    @mkandaswamy
    mkandaswamy committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    b4ecd3b View commit details
    Browse the repository at this point in the history