Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow insertion of null values in migrations tool #8297

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Conversation

jzaralim
Copy link
Contributor

Description

Fixes #8280

The toFieldType function was missing a check for NullLiteral.

Testing done

Added a unit test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner October 27, 2021 17:56
@jzaralim jzaralim requested a review from vcrfxia October 27, 2021 17:56
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @jzaralim ! Did you run a quick manual test on this as well? (The unit test is great but it'd be good to check that it works end-to-end as well. Bonus points for integration test coverage but that might be overkill for a small fix like this.)

@vcrfxia vcrfxia changed the title fix: insert null values in migrations tool fix: allow insertion of null values in migrations tool Oct 27, 2021
@jzaralim jzaralim merged commit f42d40a into master Oct 29, 2021
@jzaralim jzaralim deleted the null branch October 29, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration files throw a parsing error if you insert NULL.
2 participants