feat: build on prem images #8393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
reviewed
Nov 19, 2021
| CC_SPEC_KSQL_BRANCH = "master" | ||
| CCLOUD_DOCKER_REPO = 'confluentinc/cc-ksql' | ||
| CCLOUD_DOCKER_HOTFIX_REPO = 'confluentinc/cc-ksql-hotfix' | ||
| # need to update below automatically? |
There was a problem hiding this comment.
how is this handled in the existing scripts?
There was a problem hiding this comment.
Currently it gets updated manually ;/
There was a problem hiding this comment.
i think after we get 0.23 out, we can try to make this more automatically update
release_stabilization.py
Outdated
| mvn_docker_args["docker.registry"] = DOCKER_UPSTREAM_REGISTRY | ||
| mvn_docker_args["docker.test-registry"] = DOCKER_UPSTREAM_REGISTRY | ||
| mvn_docker_args["docker.upstream-tag"] = CP_VERSION + "-latest" | ||
| mvn_docker_args["skip.docker.build"] = "true" |
There was a problem hiding this comment.
do we want to skip the docker build? I'm a bit confused. Looking at what we used to have:
mvn --batch-mode -Pjenkins clean package dependency:analyze site validate -U \
"${MAVEN_TEST_ARG}" \
"-Dspotbugs.skip" \
"-Dcheckstyle.skip" \
"-Ddocker.tag=${MAVEN_ARTIFACT_VERSION}" \
"-Ddocker.registry=${DOCKER_REGISTRY}" \
"-Ddocker.upstream-tag=${UPSTREAM_VERSION}-latest" \
"-Dskip.docker.build=false"
(copying source since it's not a public repo: https://github.com/confluentinc/ksqldb-release/blob/5ef81dff58c19350d0c7496a251a8f6c7a2945c0/build-packages.sh#L167-L174)
are those the right original lines that build the docker image?
There was a problem hiding this comment.
nope you're right, this was just a mistake, good catch!
AlanConfluent
approved these changes
Nov 22, 2021
nateab
added a commit
that referenced
this pull request
Nov 22, 2021
* fix: add more scripts * feat: build on prem images * fix: remove extra files for now * chore: swap boolean values, so we dont skip docker build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add scripts to stabilization callback in order to build on prem docker images for standalone ksqldb releases
Testing done
No behaviour change for ksqldb.
Reviewer checklist