feat: indicate header columns in source descriptions #8475
Conversation
| @@ -31,22 +31,26 @@ | |||
|
|
|||
| public enum FieldType { | |||
| SYSTEM, // To be removed in the future. 0.9 saw this value no longer used. | |||
There was a problem hiding this comment.
This can be removed, right? I don't see being used either.
There was a problem hiding this comment.
The purpose of keeping this was so that pre-0.9 servers could still work with newer CLIs. I'm not sure how many people are still using 0.9, but I think this is easy enough to just keep anyway. This does raise a good point though - the changes in this PR would make HEADERS require the newest CLI. Are we okay with that?
|
|
||
| @JsonCreator | ||
| public FieldInfo( | ||
| @JsonProperty(value = "name", required = true) final String name, | ||
| @JsonProperty(value = "schema", required = true) final SchemaInfo schema, | ||
| @JsonProperty("fieldType") final Optional<FieldType> type | ||
| @JsonProperty("fieldType") final Optional<FieldType> type, | ||
| @JsonProperty("headerKey") final Optional<String> headerKey |
There was a problem hiding this comment.
Seems this field is optional in different places. What if you create another constructor that defaults to Optional.empty()?
|
|
||
| Queries that read from this TABLE | ||
| ----------------------------------- | ||
| readId (ERROR) : read query |
There was a problem hiding this comment.
Yeah, all the source description tests have query errors to test printing errors
| final String headerType; | ||
| if (field.getHeaderKey().isPresent()) { | ||
| headerType = "(header('" + field.getHeaderKey().get() + "'))"; | ||
| } else { | ||
| headerType = "(headers)"; | ||
| } |
There was a problem hiding this comment.
Tip
final String headerType = field.getHeaderKey()
.map(k -> "(header('" + k + "'))")
.orElse(() -> "(headers)");
Description
DESCRIBEstatements will indicate which columns are headers, for exampleTesting done
Manual, unit, console tests
Reviewer checklist