Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ksql): add ifExists/ifNotExist parameters to java client connector functions #8851

Merged
merged 3 commits into from
Mar 7, 2022
Merged

fix(ksql): add ifExists/ifNotExist parameters to java client connector functions #8851

merged 3 commits into from
Mar 7, 2022

Conversation

jzaralim
Copy link
Contributor

@jzaralim jzaralim commented Mar 5, 2022

Description

Adds an optional ifExist parameter to dropConnector() and ifNotExist to createConnector()

These are the java client changes needed for #8014. The migrations tool changes will be in another PR.

Testing done

Unit + integration

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested review from a team and JimGalasyn as code owners March 5, 2022 00:15
@jzaralim jzaralim mentioned this pull request Mar 7, 2022
Merged
2 tasks
jnh5y
jnh5y approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@jnh5y jnh5y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@jzaralim jzaralim merged commit eaf2b1f into master Mar 7, 2022
@jzaralim jzaralim deleted the client-changes branch March 7, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnh5y jnh5y jnh5y approved these changes

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jzaralim @jnh5y @JimGalasyn