Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ambiguous reference to close issue #9167

Merged
merged 1 commit into from
Jun 2, 2022
Merged

fix: ambiguous reference to close issue #9167

merged 1 commit into from
Jun 2, 2022

Conversation

pgaref
Copy link
Member

@pgaref pgaref commented Jun 2, 2022

Description

Fixing ambiguous ref issue: https://jenkins.confluent.io/job/confluentinc/job/ksql/job/master/10

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@pgaref pgaref requested a review from a team as a code owner June 2, 2022 19:23
@pgaref pgaref requested a review from jnh5y June 2, 2022 19:23
jnh5y
jnh5y approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@jnh5y jnh5y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:!

@pgaref pgaref merged commit 2e7d0db into confluentinc:master Jun 2, 2022
@pgaref pgaref deleted the fix_close_ref branch June 2, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnh5y jnh5y jnh5y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pgaref @jnh5y