Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allows results from CAST to compared. #9186

Merged
merged 3 commits into from Jun 8, 2022
Merged

fix: Allows results from CAST to compared. #9186

merged 3 commits into from Jun 8, 2022

Conversation

jnh5y
Copy link
Member

@jnh5y jnh5y commented Jun 8, 2022

Address #9185

Testing done

Just a quick unit test to show that the Java code can be compiled and evaluated.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jnh5y jnh5y requested a review from a team as a code owner June 8, 2022 00:54
suhas-satish
suhas-satish approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@suhas-satish suhas-satish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix.

@jnh5y jnh5y merged commit 3defb6b into master Jun 8, 2022
@jnh5y jnh5y deleted the fix-9185 branch June 8, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhas-satish suhas-satish suhas-satish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnh5y @suhas-satish