Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow YATT to insert into and check contents of DDL sources #9321

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

jzaralim
Copy link
Contributor

Description

Fixes #6113 and #6058

The issue is that the testing tool works by creating a TopologyTestDriver for every query, so when doing insertions and checking values, it looks for drivers. DDL sources are not queries though, so YATT ends up not finding a driver. The fix here is to register a driver with an empty topology for every DDL source.

Testing done

Added a test to the testing tool test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim marked this pull request as ready for review July 20, 2022 18:16
@jzaralim jzaralim requested a review from a team as a code owner July 20, 2022 18:16
Copy link
Member

@jnh5y jnh5y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KsqlTester support for ASSERT VALUES for DDL topics
2 participants