Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Support Bytes to UUID UDF Function #9640

Merged
merged 10 commits into from
Oct 20, 2022
Merged

feat:Support Bytes to UUID UDF Function #9640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a3322f8
feat:Support Bytes to UUID UDF Function
pkgonan Oct 12, 2022
a7d731f
add test
pkgonan Oct 12, 2022
1b83cdf
Merge branch 'master' into feature/toUUID
pkgonan Oct 16, 2022
6c4b8ea
Refactor
pkgonan Oct 16, 2022
9fd9521
Rename method
pkgonan Oct 16, 2022
8545a11
Merge branch 'confluentinc:master' into feature/toUUID
pkgonan Oct 18, 2022
20e29a0
Merge branch 'confluentinc:master' into feature/toUUID
pkgonan Oct 19, 2022
3394f49
Merge branch 'master' into feature/toUUID
pkgonan Oct 19, 2022
6502006
Merge branch 'feature/toUUID' of https://github.com/pkgonan/ksql into…
pkgonan Oct 19, 2022
b39971c
Merge branch 'confluentinc:master' into feature/toUUID
pkgonan Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ksqldb-engine/src/main/java/io/confluent/ksql/function/udf/string/Uuid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
import io.confluent.ksql.function.FunctionCategory;
import io.confluent.ksql.function.udf.Udf;
import io.confluent.ksql.function.udf.UdfDescription;
import io.confluent.ksql.function.udf.UdfParameter;
import java.nio.BufferUnderflowException;
import java.nio.ByteBuffer;

@UdfDescription(
name = "UUID",
Expand All @@ -31,4 +34,20 @@ public class Uuid {
public String uuid() {
return java.util.UUID.randomUUID().toString();
}

@Udf
public String uuid(@UdfParameter final ByteBuffer bytes) {
if (bytes == null || bytes.capacity() != 16) {
return null;
}

try {
final long firstLong = bytes.getLong();
final long secondLong = bytes.getLong();

return new java.util.UUID(firstLong, secondLong).toString();
} catch (BufferUnderflowException ex) {
return null;
}
}
}
42 changes: 36 additions & 6 deletions ksqldb-engine/src/test/java/io/confluent/ksql/function/udf/string/UuidTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@

package io.confluent.ksql.function.udf.string;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.isIn;
import org.junit.Before;
import org.junit.Test;

import java.nio.ByteBuffer;
import java.util.Arrays;
import java.util.HashSet;
import java.util.Set;
import org.junit.Before;
import org.junit.Test;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.*;

public class UuidTest {

Expand Down Expand Up @@ -59,4 +59,34 @@ public void shouldHaveCorrectOutputFormat() {
}
}

@Test
public void nullValueShouldReturnNullValue() {
final String uuid = udf.uuid(null);

assertThat(uuid, is(nullValue()));
}

@Test
public void invalidCapacityShouldReturnNullValue() {
final ByteBuffer bytes = ByteBuffer.wrap(new byte[17]);

final String uuid = udf.uuid(bytes);

assertThat(uuid, is(nullValue()));
}

@Test
public void shouldReturnCorrectOutputFormat() {
// aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee
final String anUuid = udf.uuid();

final java.util.UUID uuid = java.util.UUID.fromString(anUuid);
final ByteBuffer bytes = ByteBuffer.wrap(new byte[16]);
bytes.putLong(uuid.getMostSignificantBits());
bytes.putLong(uuid.getLeastSignificantBits());
byte[] byteArrays = bytes.array();

final String toUuid = udf.uuid(ByteBuffer.wrap(byteArrays));
assertThat(toUuid, is(anUuid));
}
}