fix: Set timeout for pull query forwarded requsts to 20s #9823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateab
approved these changes
Mar 9, 2023
| if (configOverrides.containsKey(KsqlConfig.KSQL_QUERY_PULL_FORWARDING_TIMEOUT_MS_CONFIG)) { | ||
| return (Long) configOverrides.get(KsqlConfig.KSQL_QUERY_PULL_FORWARDING_TIMEOUT_MS_CONFIG); | ||
| } | ||
| return ksqlConfig.getLong(KsqlConfig.KSQL_QUERY_PULL_FORWARDING_TIMEOUT_MS_CONFIG); |
There was a problem hiding this comment.
shouldnt this just be returning KsqlConfig.KSQL_QUERY_PULL_FORWARDING_TIMEOUT_MS_DEFAULT if no override is found
There was a problem hiding this comment.
If you do that, you won't be able to set this value in the config file. If you do ksqlConfig.getLong(KsqlConfig.KSQL_QUERY_PULL_FORWARDING_TIMEOUT_MS_CONFIG);, it will attempt to find it in the config file, and if not, default to KSQL_QUERY_PULL_FORWARDING_TIMEOUT_MS_DEFAULT.
AlanConfluent
force-pushed
the
pull_query_timeout
branch
from
a9534d4
to
1573ab2
Compare
AlanConfluent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets a timeout for pull query requests which are forwarded to 20s by default, though allows it to be set by the client.
Testing done
Unit tests, plus was able to test manually.
Reviewer checklist