Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MD5 hash UDF #9880

Merged
merged 6 commits into from May 16, 2023
Merged

feat: add MD5 hash UDF #9880

merged 6 commits into from May 16, 2023

Conversation

derekjn
Copy link
Contributor

@derekjn derekjn commented Apr 19, 2023

Description

Adds a new MD5 UDF that takes a string as input and outputs the hex-encoded MD5 hash of the string.

Testing done

  • Unit tests
  • Functional tests
  • Historical query plan

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@derekjn derekjn requested review from a team and JimGalasyn as code owners April 19, 2023 22:52
@derekjn derekjn requested review from spena and vcrfxia April 19, 2023 22:54
@cbsmith
Copy link

cbsmith commented Apr 19, 2023

Not to look a gift horse in the mouth, but is there a reason to add MD5 instead of modern secure hashes like SHA-2 that are still considered safe to use for security purposes?

@derekjn
Copy link
Contributor Author

derekjn commented Apr 19, 2023

Not to look a gift horse in the mouth, but is there a reason to add MD5 instead of modern secure hashes like SHA-2 that are still considered safe to use for security purposes?

Hey @cbsmith! MD5 was added specifically due to a number of users who require it. Do you require a SHA-2 built-in?

@derekjn derekjn merged commit d8eac13 into master May 16, 2023
@derekjn derekjn deleted the md5-hash branch May 16, 2023 21:42
ConfluentJenkins pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants