Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak when producev() fails #1478

Closed
edenhill opened this issue Oct 21, 2017 · 1 comment
Closed

Memory leak when producev() fails #1478

edenhill opened this issue Oct 21, 2017 · 1 comment
Labels
bug producer

Comments

@edenhill
Copy link
Contributor

edenhill commented Oct 21, 2017 •
edited

Description

The s_rkt rkt shared reference is not destroyed when msg_new() in producev() fails, typically due to QUEUE_FULL.

The lost reference potentially triggers hang-on-termination.

This was originally reported by @fede1024

How to reproduce

Set low queue.buffering.max.messages or construct a too large message and call producev() until it fails.
edenhill added a commit that referenced this issue Oct 21, 2017
@edenhill
Fix memory leak when producev() fails (#1478)
0f30aec
@fede1024
Copy link
Contributor

I can confirm that after the fix I don't see the memory leak in valgrind anymore (see output before and after the fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug producer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edenhill @fede1024