Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning for allow.auto.create.topics with producer #3952

Merged

Commits on Nov 7, 2022

  1. Remove warning for allow.auto.create.topics with producer

    Also improves the documentation around this property.
    
    This solves the following problem:
    
    The property "allow.auto.create.topics" is supposed to be a consumer
    property, but we are setting it (and it is affecting the behaviour of)
    both the consumer and producer. It gives a warning if we change it in
    the producer, but works nevertheless.
    
    (the default value for the producer is true)
    
    One of the effects is that if a user is using their producer as an
    adminclient, a call to get metadata for a topic might create that
    topic, and if the user specifies allow.auto.create.topics, then they
    get a warning.
    
    Unfortunately, we even recommend using a producer with the above
    setting (see INTRODUCTION.md).
    
    A knock on effect is that both the go and python clients use a producer
    internally for their adminclients so the user has to either live with
    a call to GetMetadata creating topics, or with the warning.
    
    The java client only allows this property to be set on the consumer,
    which makes it more confusing.
    milindl committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3c78315 View commit details
    Browse the repository at this point in the history