-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental alter configs implementation [KIP-339] #4110
Conversation
f202256
to
c164e25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first-pass review, will look into this again later
0e2fdf9
to
3c746e5
Compare
ConfigEntry before it fails on the broker or when parsing the result
3d1f233
to
fddd40e
Compare
rd_kafka_resp_err_t in new functions
incremental alter configs
to rd_kafka_ConfigResource_set_incremental_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review related to example, test and structs. Checking implementation in details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Work.
LGTM!
tests only with broker version >= 2.3.0
KIP-339 Incremental Alter Configs Implementation.
Supporting Set, Remove, Append and Subtract Operations.