Incremental alter configs implementation [KIP-339] #4110

PrasanthV454 · 2022-12-16T12:43:17Z

KIP-339 Incremental Alter Configs Implementation.
Supporting Set, Remove, Append and Subtract Operations.

src/rdkafka.h

src/rdkafka_admin.c

milindl

Did a first-pass review, will look into this again later

src/rdkafka.h

INTRODUCTION.md

src/rdkafka_admin.c

and AlterConfigs version to 2

ConfigEntry before it fails on the broker or when parsing the result

rd_kafka_resp_err_t in new functions

incremental alter configs

to rd_kafka_ConfigResource_set_incremental_config

pranavrth

First round of review related to example, test and structs. Checking implementation in details.

CHANGELOG.md

examples/incremental_alter_configs.c

src/rdkafka.h

src/rdkafka_admin.h

src/rdkafka.h

src/rdkafka_admin.h

src/rdkafka_admin.c

src/rdkafka.h

tests/test.c

src/rdkafka_admin.c

src/rdkafka_request.c

src/rdkafka_admin.c

rd_kafka_AlterOperation_t

altering broker configs

src/rdkafka.h

src/rdkafka_admin.c

pranavrth

Good Work.

LGTM!

tests only with broker version >= 2.3.0

src/rdkafka_admin.c

to add_incremental_config

PrasanthV454 marked this pull request as ready for review December 20, 2022 10:39

PrasanthV454 requested review from a team and edenhill December 20, 2022 10:40

mahajanadhitya reviewed Jan 27, 2023

View reviewed changes

src/rdkafka.h Outdated Show resolved Hide resolved

mahajanadhitya reviewed Jan 27, 2023

View reviewed changes

src/rdkafka_admin.c Show resolved Hide resolved

PrasanthV454 added 5 commits February 6, 2023 02:48

incremental alter configs implementation

5451d69

added simple test to test.c

1fb808a

incremental alter enum fix

2c6b6b5

Api Version revert max to zero

af9b012

latest changes update

c164e25

PrasanthV454 force-pushed the feature/incremental-alter-KIP339 branch from f202256 to c164e25 Compare February 5, 2023 22:09

PrasanthV454 added 4 commits February 6, 2023 03:42

removed temp files

a9f24f9

removed temp files

de30be6

exported append,subtract and delete

3db3b75

style errors fixed

da3d4f1

PrasanthV454 requested review from emasab, pranavrth and milindl and removed request for edenhill February 6, 2023 08:34

milindl reviewed Feb 16, 2023

View reviewed changes

emasab added 6 commits May 30, 2023 10:10

Merge branch 'master' into feature/incremental-alter-KIP339

74f053d

Upgrade IncrementalAlterConfigs version to 1

0abdca2

and AlterConfigs version to 2

Address comments

98816ed

Documentation fixes

96f13bb

Add example

e295a28

CMake fix

3c746e5

emasab force-pushed the feature/incremental-alter-KIP339 branch from 0e2fdf9 to 3c746e5 Compare May 31, 2023 06:38

Fail early on duplicate ConfigResource or

fddd40e

ConfigEntry before it fails on the broker or when parsing the result

emasab force-pushed the feature/incremental-alter-KIP339 branch from 3d1f233 to fddd40e Compare June 1, 2023 09:39

emasab changed the title ~~incremental alter configs implementation~~ [KIP-339] incremental alter configs implementation Jun 1, 2023

emasab changed the title ~~[KIP-339] incremental alter configs implementation~~ Incremental alter configs implementation [KIP-339] Jun 1, 2023

emasab added 5 commits June 6, 2023 12:33

Return rd_kafka_error_t * instead of

c33e72b

rd_kafka_resp_err_t in new functions

Doxygen fixes

fd23815

Changelog entry

9991b3c

Use single function for all the

e80b257

incremental alter configs

Rename rd_kafka_ConfigResource_incremental_alter_config

a63ca7f

to rd_kafka_ConfigResource_set_incremental_config

pranavrth requested changes Jun 23, 2023

View reviewed changes

pranavrth reviewed Jun 26, 2023

View reviewed changes

src/rdkafka_admin.c Show resolved Hide resolved

src/rdkafka_request.c Show resolved Hide resolved

src/rdkafka_admin.c Outdated Show resolved Hide resolved

emasab added 5 commits June 29, 2023 19:44

Documentation for rd_kafka_AlterConfigOpType_t

d81c161

Address comments

fd209ae

rd_kafka_AlterOperation_t doc

c462e01

Remove previous never really used

b233fea

rd_kafka_AlterOperation_t

Merge branch 'master' into feature/incremental-alter-KIP339

82c8278

emasab requested a review from pranavrth June 30, 2023 14:07

emasab added 3 commits July 3, 2023 13:15

Revert broker option to default if

17c0a7c

altering broker configs

Documentation about broker option.

eb0d852

Test healper with different resource type

6976690

pranavrth requested changes Jul 3, 2023

View reviewed changes

src/rdkafka.h Outdated Show resolved Hide resolved

src/rdkafka_admin.c Show resolved Hide resolved

Fix parameter type and documentation.

0370ad0

pranavrth approved these changes Jul 3, 2023

View reviewed changes

Incremental alter configs integration

ee26cd5

tests only with broker version >= 2.3.0

pranavrth reviewed Jul 5, 2023

View reviewed changes

src/rdkafka_admin.c Outdated Show resolved Hide resolved

emasab added 3 commits July 5, 2023 10:53

Rename set_incremental_config

9cbc19d

to add_incremental_config

Merge branch 'master' into feature/incremental-alter-KIP339

f88940c

Changelog contribution

df55c44

emasab merged commit 53a6a50 into master Jul 10, 2023
2 checks passed

emasab deleted the feature/incremental-alter-KIP339 branch July 10, 2023 17:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incremental alter configs implementation [KIP-339] #4110

Incremental alter configs implementation [KIP-339] #4110

PrasanthV454 commented Dec 16, 2022 •

edited

milindl left a comment

pranavrth left a comment

pranavrth left a comment

Incremental alter configs implementation [KIP-339] #4110

Incremental alter configs implementation [KIP-339] #4110

Conversation

PrasanthV454 commented Dec 16, 2022 • edited

milindl left a comment

Choose a reason for hiding this comment

pranavrth left a comment

Choose a reason for hiding this comment

pranavrth left a comment

Choose a reason for hiding this comment

PrasanthV454 commented Dec 16, 2022 •

edited