Fix close blocked by refcnt in test 0113. #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaks a circular dependency from rko to rktp and back that prevents the toppar being destroyed.
pranavrth
requested changes
Feb 13, 2023
|
I see that the assertion fails, here https://confluentinc.semaphoreci.com/jobs/f3de9229-85de-4bb0-914f-3daf8b1f89d3#L5575 |
|
@milindl : seen that, I'm looking for a different fix. |
milindl
approved these changes
Feb 23, 2023
pranavrth
requested changes
Feb 23, 2023
emasab
force-pushed
the
feature/fix-close-blocked-by-recount
branch
from
c0b1bb6
to
53dedbf
Compare
pranavrth
reviewed
Mar 2, 2023
pranavrth
approved these changes
Mar 9, 2023
|
@pranavrth no, it's just for leaving the CHANGELOG always ready for a release. |
7 tasks
pranavrth
pushed a commit
that referenced
this pull request
Mar 13, 2023
Breaks a circular dependency from rko to rktp and back that prevents the toppar from being destroyed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks a circular dependency from
rko to rktp and back that prevents
the toppar being destroyed.