Fixed issues related to store_offset and next_offset during Barrier op in consume batch API #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pranavrth
commented
Mar 6, 2023
pranavrth
commented
- Fixes app_offset and store_offset getting updated after reading each messages. This would have resulted in incorrect app_offset and store_offset in case of Barrier op purging some messages.
- Fixes pause and resume skipping some offsets in case of Barrier op due to the above app_offset update.
…k pause and resume withing same consume batch
* Fix purge TAILQ * Remove some memory leaks * Fix type warnings
emasab
approved these changes
Mar 22, 2023
emasab
pushed a commit
that referenced
this pull request
Mar 22, 2023
… in consume batch API (#4208) these offsets were set before the batch was completed, making it possible to commit offsets that had not been received by the application, or to skip messages after a resume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.