-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KIP-235 implementation #4292
Conversation
Semaphore PR corresponding - #4307 |
Update supported kips section as well here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the supported KIPs section as well
Verified from that all the tests except 0017_compression work when running individually from
This above error is occurring even when running with the latest master, so is unrelated to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice Work.
Just a couple of points we need to confirm with @emasab.
Correct the description of the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thanks Anchit!
Changes done
Add functionality to support KIP-235. Kept the implementation similar to the Java client in apache/kafka#4485
resolve.canonical.bootstrap.servers.only
. User should enable this if they are specifying DNS aliases in the bootstrap servers.Testing
Manually. Adding automated test will probably need some sort of integration with a mock DNS server within librdkafka.
Steps:
./../../scripts/cli/playground run -f start.sh --disable-ksqldb --disable-control-center
./etc/hosts
file add two new lines, replacing172.18.0.5
with the actual address of the broker container.randomExample.com:9092
andclient.dns.lookup
set toresolve_canonical_bootstrap_servers_only
to connect with the Kerberos protected Kafka broker.client.dns.lookup
is not set, the client is unable to connect with the broker.