Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIP-848] HB Error Code, Partial ack flow, OffsetCommit Request, Response and various fixes #4634

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

pranavrth
Copy link
Member

@pranavrth pranavrth commented Mar 6, 2024

Added Heartbeat Errorcodes, OffsetCommit Request, OffsetCommit Response and fixed multiple issues including segfaults

  • Added error handling to ConsumerGroupHeartbeat API
  • Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
  • Added partial acknowledgement flow
  • Upgraded OffsetCommit Request and response to v9
  • Fixed metadata being called with duplicate topic id
  • Fixed next_target_assignment not getting reset to NULL
  • Fixed member stuck if fenced during rebalancing
  • Fixed segfault with current and target assignment while resetting consumer group
  • Fixed segfault due to deleted topic in metadata
  • Fixed leave not being called if the consumer without any assignment leaves

@pranavrth pranavrth changed the title Last implementation changes before EA [KIP-848] Last implementation changes before EA Mar 6, 2024
@pranavrth
Copy link
Member Author

Rebased with dev_kip848 branch version of #4601

@pranavrth pranavrth force-pushed the dev_kip848_last_implementation_changes_ea branch from fe37324 to 4565547 Compare March 6, 2024 12:21
OffsetCommit Response and fixed multiple issues including segfaults

- Added error handling to ConsumerGroupHeartbeat API
- Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
- Added partial acknowledgement flow
- Upgraded OffsetCommit Request and response to v9
- Fixed metadata being called with duplicate topic id
- Fixed next_target_assignment not getting reset to NULL
- Fixed member stuck if fenced during rebalancing
- Fixed segfault with current and target assignment while resetting consumer group
- Fixed segfault due to deleted topic in metadata
- Fixed leave not being called if the consumer without any assignment leaves
@pranavrth pranavrth force-pushed the dev_kip848_last_implementation_changes_ea branch from 4565547 to b72fced Compare March 6, 2024 13:16
@pranavrth pranavrth changed the title [KIP-848] Last implementation changes before EA [KIP-848] HB Error Code, Partial ack flow, OffsetCommit Request, Response and various fixes Mar 7, 2024
examples/consumer.c Outdated Show resolved Hide resolved
src/rdkafka.h Outdated Show resolved Hide resolved
src/rdkafka.h Outdated Show resolved Hide resolved
src/rdkafka.h Outdated Show resolved Hide resolved
src/rdkafka.h Outdated Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_request.h Outdated Show resolved Hide resolved
INTRODUCTION.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other comments about error handling

src/rdkafka_cgrp.c Outdated Show resolved Hide resolved
src/rdkafka_cgrp.c Outdated Show resolved Hide resolved
src/rdkafka_cgrp.c Outdated Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_cgrp.c Outdated Show resolved Hide resolved
src/rdkafka_cgrp.c Outdated Show resolved Hide resolved
src/rdkafka_cgrp.c Outdated Show resolved Hide resolved
src/rdkafka_cgrp.c Outdated Show resolved Hide resolved
src/rdkafka_cgrp.c Show resolved Hide resolved
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Pranav!

@emasab emasab merged commit 228362d into dev_kip848 Mar 12, 2024
4 checks passed
@emasab emasab deleted the dev_kip848_last_implementation_changes_ea branch March 12, 2024 15:10
emasab pushed a commit that referenced this pull request Mar 21, 2024
…onse and various fixes (#4634)

- Added error handling to ConsumerGroupHeartbeat API
- Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
- Added partial acknowledgement flow
- Upgraded OffsetCommit Request and response to v9
- Fixed metadata being called with duplicate topic id
- Fixed next_target_assignment not getting reset to NULL
- Fixed member stuck if fenced during rebalancing
- Fixed segfault with current and target assignment while resetting consumer group
- Fixed segfault due to deleted topic in metadata
- Fixed leave not being called if the consumer without any assignment leaves
emasab pushed a commit that referenced this pull request Apr 5, 2024
…onse and various fixes (#4634)

- Added error handling to ConsumerGroupHeartbeat API
- Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
- Added partial acknowledgement flow
- Upgraded OffsetCommit Request and response to v9
- Fixed metadata being called with duplicate topic id
- Fixed next_target_assignment not getting reset to NULL
- Fixed member stuck if fenced during rebalancing
- Fixed segfault with current and target assignment while resetting consumer group
- Fixed segfault due to deleted topic in metadata
- Fixed leave not being called if the consumer without any assignment leaves
emasab pushed a commit that referenced this pull request Apr 11, 2024
…onse and various fixes (#4634)

- Added error handling to ConsumerGroupHeartbeat API
- Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
- Added partial acknowledgement flow
- Upgraded OffsetCommit Request and response to v9
- Fixed metadata being called with duplicate topic id
- Fixed next_target_assignment not getting reset to NULL
- Fixed member stuck if fenced during rebalancing
- Fixed segfault with current and target assignment while resetting consumer group
- Fixed segfault due to deleted topic in metadata
- Fixed leave not being called if the consumer without any assignment leaves
emasab pushed a commit that referenced this pull request Apr 15, 2024
…onse and various fixes (#4634)

- Added error handling to ConsumerGroupHeartbeat API
- Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
- Added partial acknowledgement flow
- Upgraded OffsetCommit Request and response to v9
- Fixed metadata being called with duplicate topic id
- Fixed next_target_assignment not getting reset to NULL
- Fixed member stuck if fenced during rebalancing
- Fixed segfault with current and target assignment while resetting consumer group
- Fixed segfault due to deleted topic in metadata
- Fixed leave not being called if the consumer without any assignment leaves
emasab pushed a commit that referenced this pull request Apr 18, 2024
…onse and various fixes (#4634)

- Added error handling to ConsumerGroupHeartbeat API
- Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
- Added partial acknowledgement flow
- Upgraded OffsetCommit Request and response to v9
- Fixed metadata being called with duplicate topic id
- Fixed next_target_assignment not getting reset to NULL
- Fixed member stuck if fenced during rebalancing
- Fixed segfault with current and target assignment while resetting consumer group
- Fixed segfault due to deleted topic in metadata
- Fixed leave not being called if the consumer without any assignment leaves
anchitj pushed a commit that referenced this pull request Jun 10, 2024
…onse and various fixes (#4634)

- Added error handling to ConsumerGroupHeartbeat API
- Added type new errors - UNRELEASED_INSTANCE_ID and UNSUPPORTED_ASSIGNOR
- Added partial acknowledgement flow
- Upgraded OffsetCommit Request and response to v9
- Fixed metadata being called with duplicate topic id
- Fixed next_target_assignment not getting reset to NULL
- Fixed member stuck if fenced during rebalancing
- Fixed segfault with current and target assignment while resetting consumer group
- Fixed segfault due to deleted topic in metadata
- Fixed leave not being called if the consumer without any assignment leaves
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants