Fix to main loop timeout calculation leading to a tight loop for a max period of 1 ms #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
force-pushed
the
dev_fix_main_thread_tight_loop
branch
from
1315712
to
37b4ef4
Compare
emasab
force-pushed
the
dev_metadata_cache_topic_id_and_fixes
branch
from
ba3ee8d
to
f405243
Compare
emasab
force-pushed
the
dev_fix_main_thread_tight_loop
branch
from
37b4ef4
to
f5ffbf8
Compare
emasab
force-pushed
the
dev_metadata_cache_topic_id_and_fixes
branch
from
f405243
to
4dd41b7
Compare
emasab
force-pushed
the
dev_fix_main_thread_tight_loop
branch
from
f5ffbf8
to
7403c10
Compare
pranavrth
reviewed
Apr 4, 2024
| rd_kafka_q_serve(rk->rk_ops, (int)(sleeptime / 1000), 0, | ||
| /* Use ceiling division to avoid calling serve with a 0 ms | ||
| * timeout in a tight loop until 1 ms has passed. */ | ||
| int timeout_ms = (sleeptime + 999) / 1000; |
There was a problem hiding this comment.
I had one concern with the overflow but that will never happen as we use CLOCK_MONOTONIC and hence will never reach the limit for rd_ts_t.
Comment on lines
+14
to
+11
| * Fix to main loop timeout calculation leading to a tight loop for a | ||
| max period of 1 ms (#4671). |
There was a problem hiding this comment.
Let's use something easier to understand than tight loop. The later statement is more comprehendible than this.
pranavrth
previously approved these changes
Apr 4, 2024
emasab
changed the base branch from
dev_metadata_cache_topic_id_and_fixes
to
master
leading to a tight loop for a max period of 1 ms When the main thread loop was awakened less than 1 ms before the expiration of a timeout, it was serving with a zero timeout, leading to increased CPU usage until the timeout was reached. Happening since 1.x
emasab
force-pushed
the
dev_fix_main_thread_tight_loop
branch
from
2b56329
to
6a8f931
Compare
pranavrth
approved these changes
Apr 5, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the main thread loop was awakened less than 1 ms before the expiration of a timeout, it was serving with a zero timeout, leading to increased CPU usage until the timeout was reached. Happening since 1.x