Fix for a wrong error returned on full metadata refresh before joining a consumer group #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
799491c
to
3e05712
Compare
emasab
force-pushed
the
dev_fix_metadata_cache_cleared_full_request
branch
from
6f3c1b5
to
b27ccc6
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
3e05712
to
fc00cfc
Compare
emasab
force-pushed
the
dev_fix_metadata_cache_cleared_full_request
branch
2 times, most recently
from
d4d40c1
to
d9540da
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
fc00cfc
to
420116d
Compare
pranavrth
requested changes
Apr 12, 2024
src/rdkafka_cgrp.c
Outdated
Comment on lines
2336
to
2339
| /* Insert all non-wildcard topics in cache. */ | ||
| rd_kafka_metadata_cache_hint_rktparlist( | ||
| rkcg->rkcg_rk, rkcg->rkcg_subscription, NULL, 0 /*dont replace*/); | ||
|
|
There was a problem hiding this comment.
We can keep this here as well I think as its just adding the hints. This function is used during rejoin as well.
src/rdkafka_cgrp.c
Outdated
| rkcg->rkcg_subscription = rktparlist; | ||
| if (rkcg->rkcg_subscription) { | ||
| /* Insert all non-wildcard topics in cache immediately. | ||
| * to avoid problems with subsequent metadata |
There was a problem hiding this comment.
What problems? Let's elaborate more in the comments.
emasab
force-pushed
the
dev_fix_metadata_cache_cleared_full_request
branch
from
d9540da
to
a159193
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
420116d
to
60045b7
Compare
pranavrth
requested changes
Apr 14, 2024
tests/0146-metadata_mock.c
Outdated
| test_mock_cluster_destroy(mcluster); | ||
|
|
||
| SUB_TEST_PASS(); | ||
| } | ||
|
|
||
| int main_0146_metadata_mock(int argc, char **argv) { | ||
| TEST_SKIP_MOCK_CLUSTER(0); | ||
|
|
||
| do_test_metadata_persists_in_cache("range"); | ||
|
|
|
|
||
| int main_0146_metadata_mock(int argc, char **argv) { | ||
| TEST_SKIP_MOCK_CLUSTER(0); | ||
|
|
||
| do_test_metadata_persists_in_cache("range"); | ||
|
|
||
| do_test_metadata_persists_in_cache("cooperative-sticky"); | ||
| do_test_metadata_call_before_join(); |
CHANGELOG.md
Outdated
| @@ -36,6 +38,10 @@ librdkafka v2.3.1 is a maintenance release: | |||
| refreshes and occasional `UNKNOWN_TOPIC_OR_PART` errors. Solved by updating | |||
| cache for existing or hinted entries instead of clearing them. | |||
| Happening since 2.1.0 (#4677). | |||
| * A metadata call before member joins consumer group, | |||
There was a problem hiding this comment.
Can we add the issue as well here for all the previous fixes as well?
Base automatically changed from
dev_fix_metadata_cache_cleared_full_request
to
dev_kip848
April 15, 2024 07:38
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
2 times, most recently
from
78a5434
to
31fea0e
Compare
on full metadata refresh before joining a consumer group A metadata call before member joins consumer group, could lead to an `UNKNOWN_TOPIC_OR_PART` error. Solved by updating the consumer group following a metadata refresh only in safe states. Happening since 2.1.0
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
31fea0e
to
cbf2c54
Compare
emasab
added a commit
that referenced
this pull request
Apr 18, 2024
…g a consumer group (#4678) A metadata call before member joins consumer group, could lead to an `UNKNOWN_TOPIC_OR_PART` error. Solved by updating the consumer group following a metadata refresh only in safe states. Happening since 2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A metadata call before member joins
consumer group, could lead to
an
UNKNOWN_TOPIC_OR_PARTerror.Solved by updating the consumer group
following a metadata refresh only in safe states.
Happening since 2.1.0
Closes #4589